search

reifyhealth / lein-git-down

A Leiningen plugin for resolving dependencies from Git
MIT License
82 stars 6 forks source link

UPDATED - Improve Messaging [164092619] #22

Closed manderson202 closed 5 years ago

manderson202 commented 5 years ago

Closes #20 Closes #21

(PT Story)

This PR makes a couple of updates to improve messaging per the above referenced issues:

  1. Silence the gitlibs output since it can be confusing in certain situations and leads to messier output
  2. Add warning messages when a user has unsupported algorithms configured in their ssh config. The Jsch library will fail with an unhelpful NPE when this happens. Adding support for user defined algorithms is out of scope (even if they are valid in up to date SSH implementations), so instead we try to be helpful about what caused the problem.

Additionally, there is a small fix for a bug when running tests on Java >= 9.

manderson202 commented 5 years ago

@bjonica-reify made an adjustment per your comment. Thanks!

vemv commented 5 years ago

Thanks folks for this one!