search

reiinakano / xcessiv

A web-based application for quick, scalable, and automated hyperparameter tuning and stacked ensembling in Python.
http://xcessiv.readthedocs.io
Apache License 2.0
1.27k stars 105 forks source link

Move .gitignore to project root and add Python ignores #41

Closed menglewis closed 7 years ago

menglewis commented 7 years ago

I think the best practice for .gitignore is to have a single .gitignore file at the root of the project so I moved the .gitignore that was in xcessiv/ui (I think it was generated by create-react-scripts) to the project root and added some Python ignore lines.

reiinakano commented 7 years ago

I was reading about gitignore practices, and I think it's fine to let xcessiv/ui to have its own gitignore. I treat it as pretty much a separate project anyway. At least this way if create-react-app changes its gitignore in the future it'll be straightforward.

If you could restore the old gitignore file in xcessiv/ui and keep your gitignore at root (without the js specific lines) I would be happy to merge this. :)

menglewis commented 7 years ago

Cool, I reverted the .gitignore for the UI and removed JS specific lines from the root .gitignore.

reiinakano commented 7 years ago

Thanks!