Pass dThroat to calcKN() and calcIdealPressure() in tests

reilleya / openMotor

An open-source internal ballistics simulator for rocket motor experimenters

GNU General Public License v3.0

368 stars 73 forks source link

Pass dThroat to calcKN() and calcIdealPressure() in tests #167

Closed stefanor closed 3 years ago

stefanor commented 3 years ago

Fixes: #89

reilleya commented 3 years ago

Hi Stefano,

I put in some additional work to the unit tests on the staging branch a little while back, which already includes these changes. There's still a lot to do on them though, and I'd really appreciate any contributions you make! Let me know if you want ideas for more tests that would be nice to have.

-Andrew

stefanor commented 3 years ago

Aha. I'd suggest documenting that staging branch in big bold letters in the README :) And maybe making it the repo's default branch, so PRs get filed against it.

reilleya commented 3 years ago

Sorry about that! Both good points. I'll change the default branch to staging. People who want stable versions can just download a release.