search

rejuvenate / lovelace-horizon-card

Sun Card successor: Visualize the position of the Sun over the horizon.
MIT License
474 stars 35 forks source link

Fix CI build #157

Closed scinos closed 2 weeks ago

scinos commented 2 weeks ago

Pull Request Template for Home Assistant / Lovelace Card Repository

Overview

At some point we merged an incomplete yarn.lock (likely in #155), causing CI to fail. This PR fixes it by committing the missing changes in yarn.lock

Type of Change

ThomDietrich commented 2 weeks ago

Just one issue left and it seems not directly related to your changes. Do you have an idea how to fix it? Btw if you want, I would like to offer you the maintainer role for this repo? https://github.com/rejuvenate/rejuvenate/blob/master/README.md

scinos commented 2 weeks ago

Just one issue left and it seems not directly related to your changes. Do you have an idea how to fix it?

I'd need to investigate how the release process work. But my initial guess is this fails because we didn't update the version number in package.json (based on the log of the step "Run rymndhng/release-on-push-action@master").

Do you happen to know what's the release process for this package?

Btw if you want, I would like to offer you the maintainer role for this repo?

Sure! I'd love to help.

ThomDietrich commented 2 weeks ago

This issue might be related to my change here: https://github.com/rejuvenate/lovelace-horizon-card/pull/88/files but I do not see why.

The release process should be based on those labels I can assign to PRs: "norelease", "release:major", "release:minor", "release:patch". I assume the issue came up because I didn't add any of those labels to the PR. I would expect that to have the same effect as adding "norelease", which my PR #88 was supposed to ensure.