Parse images in html markdown block

relate-app / gatsby-source-strapi-graphql

A Gatsby source plugin for building websites using Strapi as a data source

BSD Zero Clause License

32 stars 9 forks source link

Parse images in html markdown block #7

Closed pepijn-vanvlaanderen closed 2 years ago

pepijn-vanvlaanderen commented 2 years ago

Thanks for the plugin, this was actually exactly the sourcing plugin we needed for Strapi!

Most often we work with the TinyMCE editor in Strapi and thus have HTML output, but we want to use inline images as well. So I extended the extractFiles function to also be able to parse images from a HTML block.

timbrandin commented 2 years ago

LGTM, but maybe we should update the readme and maybe also the configuration options if we support both markdown and html inline images, maybe we could call it inlineImages rather than markdownImages, or what do you prefer?

pepijn-vanvlaanderen commented 2 years ago

Agreed, I have updated the naming for this!

timbrandin commented 2 years ago

LGTM