search

relaton / relaton-bib

MIT License
3 stars 1 forks source link

Do not hardcode locality types #66

Open ronaldtse opened 2 years ago

ronaldtse commented 2 years ago

https://github.com/relaton/relaton-bib/blob/d8031f228edcabeeb3998ad3a93de3f506c14da0/lib/relaton_bib/bib_item_locality.rb#L16-L27

The list of types should be dynamically generated, not hardcoded in a RegEx.

andrew2net commented 2 years ago

@ronaldtse the list of types is defined in the schema. Do you mean we need to extract the list of types from the grammar?