Closed ronaldtse closed 2 years ago
@ronaldtse I see what we need to test person fullnames parsing, right? But what should we test against the list of organizations?
@andrew2net for organizations, we want to ensure that they are indeed encoded as organizations.
@ronaldtse if you mean the case when the organizations are represented as aouthor[@fullname]
then the list of organizations doesn't include names from the issue https://github.com/relaton/relaton-ietf/issues/101#issuecomment-1247849853
For example, I want to ensure that we have these tests:
When parsing rfc-index.xml entry RFC0806, Relaton will treat the author as an organization author of "National Bureau of Standards".
When generating BibXML output, the RFC 0806 author will be encoded as:
<author><organization>National Bureau of Standards</organization></author>
4712 M. Rahman,Y. Kim <author initials='M.' surname='Rahman' fullname='M. Rahman'><organization /></author> <author initials='Y.' surname='Kim' fullname='Y. Kim'><organization /></author>
@ronaldtse does the example mean that an author[@fullname]
attribute can contain 2 names and we need to transform the 2 names into 2 author elements?
(This is relevant to #102)
@ronaldtse does the example mean that an
author[@fullname]
attribute can contain 2 names and we need to transform the 2 names into 2 author elements?
This is very strange. Perhaps it's a bug at the RPC. Let me find out.
@ronaldtse does the example mean that an
author[@fullname]
attribute can contain 2 names and we need to transform the 2 names into 2 author elements?
I've checked rfc-index.xml
. The current encoding is correct and nothing special should be done for it:
<rfc-entry>
<doc-id>RFC4712</doc-id>
<title>Transport Mappings for Real-time Application Quality-of-Service Monitoring (RAQMON) Protocol Data Unit (PDU)</title>
<author>
<name>A. Siddiqui</name>
</author>
<author>
<name>D. Romascanu</name>
</author>
<author>
<name>E. Golovinsky</name>
</author>
<author>
<name>M. Rahman</name>
</author>
<author>
<name>Y. Kim</name>
</author>
<date>
<month>October</month>
<year>2006</year>
</date>
The previous
xml2rfc-bibxml
tools provide a set of expectations on the authorship conversions fromrfc-index.xml
as mentioned by @rjsparks:https://github.com/ietf-tools/bibxml-service/issues/296#issuecomment-1275227694
We should integrate these test cases from
rfc-index.xml
and their expected outputs in the rspec, in terms of:rfc-index.xml
conversion to Relaton model (or Relaton YAML)https://github.com/ietf-tools/xml2rfc-bibxml/blob/318639ce7663bf9b043bce225c04f890d0f2ac64/bibxml/bibxml-rfcs/gen-bibxml-rfcs-via-rfc-index#L44-L331
Organizations:
Persons:
The last one should probably be: