search

relayjs / relay-examples

A collection of sample Relay applications
MIT License
1.14k stars 433 forks source link

[Donot merge] intro a buggy comment #238

Open Lalitha-Iyer opened 2 years ago

Lalitha-Iyer commented 2 years ago

Repro to demo a bug with the relay compiler Bug: Adding Unicode characters in comments ( 🐛), causes the Relay compiler to error

Looking at the graphql spec notes, this feels like a bug.

How to repro

yarn build the todo example.

Error

[INFO] [default] compiling...
thread 'main' panicked at 'internal error: entered unreachable code', crates/graphql-syntax/src/lexer.rs:169:40
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error Command failed with exit code 101.
facebook-github-bot commented 2 years ago

Hi @Lalitha-Iyer!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 2 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

captbaritone commented 2 years ago

Thanks for the repro! Is there an issue in the main repository for this?

Lalitha-Iyer commented 1 year ago

Yes, there is an issue in the main repo https://github.com/facebook/relay/issues/4044