remarkjs / remark-lint-no-dead-urls

lint rule to warn when URLs are dead
https://unifiedjs.com
MIT License
78 stars 13 forks source link

Support links to private repos #49

Closed nkakouros closed 2 months ago

nkakouros commented 2 months ago

Initial checklist

Problem

I have a link in my README that points to the wiki of a private repo, e.g. https://github.com/remarkjs/remark-lint-no-dead-urls/wiki. This link is reported as dead.

Solution

It would be nice to have the option to supply a github token or a general authentication token to be used when accessing urls.

Alternatives

The only alternative is to blacklist the private repo.

wooorm commented 2 months ago

I don't see how; this project isn't specific to GH, but the entire web. You'd need to allow tokens and login flows for all websites ever. Instead: this seems quite logical. Other people who would view your readme would not be able to see that page either. I'd recommend not linking to it. Or if you do, you'd have to ignore it, and should likely write it text that it is private?

nkakouros commented 2 months ago

I see. I'll probably add a skip pattern for these links.

github-actions[bot] commented 2 months ago

Hi! This was closed. Team: If this was fixed, please add phase/solved. Otherwise, please add one of the no/* labels.

github-actions[bot] commented 2 months ago

Hi team! Could you describe why this has been marked as wontfix?

Thanks, — bb