search

remigabillet / DAT_SF_10

Repository for data science 10 course
0 stars 0 forks source link

HW1 Peer review by Tom Harel #1

Closed tomharel closed 9 years ago

tomharel commented 9 years ago

Hey Remi, Python isn't my strong suite, but I think you did a great job answering the homework. I only have 1 comment regarding the Extra Credit, see below.

-- Tom

Review:

Step 1: Great job.

Step 2: Looks good.

Extra Credit: Slight issue - you're grouping by day + hour. So if we have more than one month, you might be lumping 9/22 and 10/22 as the same day and over count. Instead I would group by date + hour.

In code: "SELECT date(timestamp) AS date, \ strftime('%H', timestamp) AS hour, \ count(_) \ FROM ga_hwlogins \ GROUP BY date, hour \ ORDER BY count() DESC \ LIMIT 5"

@regabi, @ghego, @craigsakuma, @kebaler

remigabillet commented 9 years ago

Thanks a lot Tom, this is great feedback.

On Tue, Oct 14, 2014 at 11:00 PM, tomharel notifications@github.com wrote:

Hey Remi, Python isn't my strong suite, but I think you did a great job answering the homework. I only have 1 comment regarding the Extra Credit, see below.

-- Tom

Review:

Step 1: Great job.

Step 2: Looks good.

Extra Credit: Slight issue - you're grouping by day + hour. So if we have more than one month, you might be lumping 9/22 and 10/22 as the same day and over count. Instead I would group by date + hour.

In code: "SELECT date(timestamp) AS date, \ strftime('%H', timestamp) AS hour, \ count(

_) \ FROM ga_hwlogins \ GROUP BY date, hour \ ORDER BY count() DESC \ LIMIT 5"

@regabi https://github.com/regabi, @ghego https://github.com/ghego, @craigsakuma https://github.com/craigsakuma, @kebaler https://github.com/kebaler

— Reply to this email directly or view it on GitHub https://github.com/regabi/DAT_SF_10/issues/1.