Application error on throwing response on splat route

safinn commented 4 months ago

Reproduction

https://stackblitz.com/edit/remix-run-remix-fscn1k?file=app%2Froutes%2F%24.tsx

Enabled both unstable_fogOfWar and unstable_singleFetch.
Started happening once I upgraded from v2.10.0.
Created a simple splat route to capture 404's.

Navigating to a page that does not exist causes this error:

TypeError: Cannot read properties of undefined (reading 'route')
at Meta (https://remixrunremixfscn1k-hamq-kxpnvvut--5173--70dbe416.local-credentialless.webcontainer.io/node_modules/.vite/deps/@remix-run_react.js?v=ee74eb44:3673:50)
at renderWithHooks (https://remixrunremixfscn1k-hamq-kxpnvvut--5173--70dbe416.local-credentialless.webcontainer.io/node_modules/.vite/deps/chunk-GZD7INZN.js?v=ee74eb44:11548:26)
at mountIndeterminateComponent (https://remixrunremixfscn1k-hamq-kxpnvvut--5173--70dbe416.local-credentialless.webcontainer.io/node_modules/.vite/deps/chunk-GZD7INZN.js?v=ee74eb44:14926:21)
at beginWork (https://remixrunremixfscn1k-hamq-kxpnvvut--5173--70dbe416.local-credentialless.webcontainer.io/node_modules/.vite/deps/chunk-GZD7INZN.js?v=ee74eb44:15914:22)
at beginWork$1 (https://remixrunremixfscn1k-hamq-kxpnvvut--5173--70dbe416.local-credentialless.webcontainer.io/node_modules/.vite/deps/chunk-GZD7INZN.js?v=ee74eb44:19753:22)
at performUnitOfWork (https://remixrunremixfscn1k-hamq-kxpnvvut--5173--70dbe416.local-credentialless.webcontainer.io/node_modules/.vite/deps/chunk-GZD7INZN.js?v=ee74eb44:19198:20)
at workLoopSync (https://remixrunremixfscn1k-hamq-kxpnvvut--5173--70dbe416.local-credentialless.webcontainer.io/node_modules/.vite/deps/chunk-GZD7INZN.js?v=ee74eb44:19137:13)
at renderRootSync (https://remixrunremixfscn1k-hamq-kxpnvvut--5173--70dbe416.local-credentialless.webcontainer.io/node_modules/.vite/deps/chunk-GZD7INZN.js?v=ee74eb44:19116:15)
at recoverFromConcurrentError (https://remixrunremixfscn1k-hamq-kxpnvvut--5173--70dbe416.local-credentialless.webcontainer.io/node_modules/.vite/deps/chunk-GZD7INZN.js?v=ee74eb44:18736:28)
at performConcurrentWorkOnRoot (https://remixrunremixfscn1k-hamq-kxpnvvut--5173--70dbe416.local-credentialless.webcontainer.io/node_modules/.vite/deps/chunk-GZD7INZN.js?v=ee74eb44:18684:30)

pointing to this line: https://github.com/remix-run/remix/blob/e8d1aea4fb023b0967da02914d630b1f1c4a35e4/packages/remix-react/components.tsx#L559

System Info

System:
  OS: macOS 14.5
  CPU: (10) arm64 Apple M1 Pro
  Memory: 31.69 MB / 16.00 GB
  Shell: 5.9 - /bin/zsh
Binaries:
  Node: 22.4.0
  npm: 10.8.1
  pnpm: 9.4.0
Browsers:
  Brave Browser: 126.1.67.123
  Safari: 17.5
npmPackages:
  @remix-run/dev: ^2.10.2 => 2.10.2 
  @remix-run/express: ^2.10.2 => 2.10.2 
  @remix-run/node: ^2.10.2 => 2.10.2 
  @remix-run/react: ^2.10.2 => 2.10.2 
  @remix-run/server-runtime: ^2.10.2 => 2.10.2 
  vite: ^5.3.3 => 5.3.3

Used Package Manager

pnpm

Expected Behavior

No error and for the ErrorBoundary component to be rendered from the splat route when pages that do not exist are attempted to be accessed.

Actual Behavior

Shows an application error when throwing the ResponseStub object from the splat route loader with a status of 404.

jozefmery commented 4 months ago

Throwing a plain response like so: throw new Response(undefined, { status: 404 }); also causes the issue.

brophdawg11 commented 4 months ago

This is resolved by the above PR and will be available in the next release

remix-run / remix