search

remotion-dev / remotion

🎥 Make videos programmatically with React
https://remotion.dev
Other
20.83k stars 1.05k forks source link

Private Buckets for remotion lambda #3839

Open ryanleecode opened 6 months ago

ryanleecode commented 6 months ago

Unless I'm mistaken, the remotion lambda bucket has to be public for it to work, otherwise it gets permission denied. But i don't want my remotion code and my video metadata to just be publicly accessible. Is there a solution to be able to use a private bucket?

ryanleecode commented 6 months ago

Also is there a way for disable github repo being linked in the UI. I am trying to make it as annoymous as possible if it can't be made private.

JonnyBurger commented 6 months ago

Those are both good requests! We're planning to build a proxy for S3 going through Lambda that can allow reading private buckets.

For GitHub repo UI being linked, can you create a separate issue? It does seem like two distinct things.

ryanleecode commented 6 months ago

Those are both good requests! We're planning to build a proxy for S3 going through Lambda that can allow reading private buckets.

For GitHub repo UI being linked, can you create a separate issue? It does seem like two distinct things.

Done! https://github.com/remotion-dev/remotion/issues/3839

TomaszSzymanskiDl commented 2 months ago

Hi @JonnyBurger,

Just following up on the private S3 bucket support for Remotion Lambda mentioned in issue #3839. We adhere strictly to AWS best practices, which discourage open S3 buckets due to security risks. It's important for us to keep our data secure. Any updates on the S3 proxy through Lambda or other solutions?

Thanks!

JonnyBurger commented 2 months ago

@TomaszSzymanskiDl Sorry for the late response.

There is no update on the S3 Proxy yet, though it is planned to be implemented on the future.

Remotion just needs a publicy accessible URL where the React code is hosted, which should not contain any private data (that you should pass through input props).

Here is a document explaining how it works, maybe it helps you justify a public bucket (https://www.remotion.dev/docs/lambda/faq#can-i-make-a-site-private - you can still have private items in it!)

Alternatively, you can host your bundle somewhere else and pass it to Lambda, keeping the bucket private.