search

remotion-dev / template-helloworld-javascript

Starting point for a new Remotion project in plain JS. The Hello World template, but in plain JavaScript. Recommended for people who detest TypeScript.
https://www.remotion.dev/templates/javascript
13 stars 6 forks source link

extra Compositions inside src/Video.jsx are confused and mislead #6

Open lgh06 opened 2 years ago

lgh06 commented 2 years ago

https://github.com/remotion-dev/template-helloworld-javascript/blob/a1a9655b6041f1172d6eb354ae7f27dfd74cf5d6/src/Video.jsx#L21

I think for a basic and minimal HelloWorld demo, line 21 to 36 are not nessesary in fact.
and these two extra Composition confused me a lot because there are <Logo> & <Title> & <Subtitle> inside Sequence again:
https://github.com/remotion-dev/template-helloworld-javascript/blob/a1a9655b6041f1172d6eb354ae7f27dfd74cf5d6/src/HelloWorld.jsx#L28

lgh06 commented 2 years ago

image finally I think I understand. a Sequence is not a must-need. Composition is a must-need. however still confuse a newbie.

lgh06 commented 2 years ago

https://github.com/remotion-dev/remotion/issues/738

tomByrer commented 2 years ago

I agree that the second & third <Composition> are not used.

But I would like to see extra <Composition> in the template that is actually used, so we can see how it is done & why/when it is useful.