Open septract opened 2 months ago
We should fix this at the same time as reorganizing / rationalizing the cn-tutorial directory structure.
On Fri, Jul 5, 2024 at 5:40 PM Mike Dodds @.***> wrote:
Problem: We currently have two CI scripts:
- cn-tutorial/check.sh - this runs the examples in cn-tutorial/src/example, which are used in the tutorial itself
- cn-tutorial/src/example-archive/check-all.sh - this runs all the examples in the example archive.
These scripts are gratuitously different from each other. Eg the first one counts the number of failures, and the second one doesn't.
Unifying the scripts is slightly annoying because the tutorial scripts are categorized by name, while the example archive scripts are categorized by subdirectory. But they should have the same capabilities and interface.
Desired resolution
- Scripts have the same capabilities and interface
- Scripts are called through a single top-level make check target (see
14
https://urldefense.com/v3/__https://github.com/rems-project/cn-tutorial/pull/14__;!!IBzWLUs!Ql5PrDewb76tRPWfeO_7xG5ie3j1RtfYmtC2Qz8hOISZmV6FZjVqWy0U_cNwnLo3nD4w32NfIvjVLoM2_i7E-roAwriJ$ as a starting point)
— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/rems-project/cn-tutorial/issues/38__;!!IBzWLUs!Ql5PrDewb76tRPWfeO_7xG5ie3j1RtfYmtC2Qz8hOISZmV6FZjVqWy0U_cNwnLo3nD4w32NfIvjVLoM2_i7E-uE8g103$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABVQQC6XN4YUU4CYLR4G6OLZK4HDNAVCNFSM6AAAAABKNZEFCGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM4TGMJWHE4DMMA__;!!IBzWLUs!Ql5PrDewb76tRPWfeO_7xG5ie3j1RtfYmtC2Qz8hOISZmV6FZjVqWy0U_cNwnLo3nD4w32NfIvjVLoM2_i7E-paHohb9$ . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Problem: We currently have two CI scripts:
cn-tutorial/check.sh
- this runs the examples incn-tutorial/src/example
, which are used in the tutorial itselfcn-tutorial/src/example-archive/check-all.sh
- this runs all the examples in the example archive.These scripts are gratuitously different from each other. Eg the first one counts the number of failures, and the second one doesn't.
Unifying the scripts is slightly annoying because the tutorial scripts are categorized by name, while the example archive scripts are categorized by subdirectory. But they should have the same capabilities and interface.
Desired resolution
make check
target (see #14 as a starting point)