search

remsfal / remsfal-frontend

MIT License
4 stars 43 forks source link

Feature/add home navigation #271

Closed s0571584 closed 4 days ago

s0571584 commented 1 week ago

merged remsfal main into my branch and commited changes

astanik commented 1 week ago

@s0571584 Please finish your good first issue. The deadline was already on Monday!

s0571584 commented 1 week ago

When I pull requested last week every test was green, so I thought I was done. I can't recreate the errors locally to fix them, I am trying to fix the errors I see here on GitHub. 😅But I will do it!🫡🫡

astanik commented 1 week ago

@s0571584 You are almost there. All that's missing is a test to achieve code coverage https://sonarcloud.io/summary/new_code?id=remsfal_remsfal-frontend&pullRequest=271

Here you can find a good example on how to klick the button https://github.com/remsfal/remsfal-frontend/blob/f11cf47e5e3193e54e8535448e559e24a284ddf7/test/layout/AppTopbar.spec.ts#L43

sonarcloud[bot] commented 4 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud