search

remyroy / CDDA-Game-Launcher

A Cataclysm: Dark Days Ahead launcher with additional features
MIT License
424 stars 104 forks source link

browser_download_url format change #637

Open Menschheit opened 2 years ago

Menschheit commented 2 years ago

Describe the bug The launcher keeps throwing "Errno 2 no such file or directory"

To Reproduce Steps to reproduce the behavior:

  1. All builds are unavailable in the list but the user can still click "Update game"
  2. Throwing errno 2.

Additional context The exception is thrown by self.downloading_file = open(self.downloaded_file, 'wb'). Because browser_download_url does not match the regular expression given by new_target_regex and target_regex anymore, the filenames are set to be empty.

Example of the new download url "browser_download_url": "https://github.com/CleverRaven/Cataclysm-DDA/releases/download/cdda-experimental-2022-03-10-1810/cdda-windows-tiles-x64-msvc-2022-03-10-1810.zip"

remyroy commented 2 years ago

This project is now unmaintained but there are a few alternatives if you look.

DazedNConfused- commented 2 years ago

Howdy! It has already been addressed in the two main forks going around: https://github.com/DazedNConfused-/CDDA-Game-Launcher/releases/tag/v1.6.3 and https://github.com/Fris0uman/CDDA-Game-Launcher/releases/tag/2022-03-06