search

remzi-arpacidusseau / ostep-projects

Projects for an undergraduate OS course
4.15k stars 1.19k forks source link

No warning if `/test-getreadcounts.sh` run without required dependencies #28

Open byanofsky opened 3 years ago

byanofsky commented 3 years ago

While working on initival-xv6 project, I ran the test script /test-getreadcounts.sh. Its resulting output showed test 1 had failed.

Digging deeper, I discovered the required dependency expect was not installed on my system. Directly running the test/1.run script, I received an error that expect could not be found.

However, there was no relevant warning or error displayed when I had run /test-getreadcounts.sh.

After installing expect, the test showed as passing.

spamegg1 commented 3 years ago

@byanofsky There is actually a warning, you need to look into the .err file for that particular test, and it will say something like: /usr/bin/env: 'expect': No such file or directory. But I agree it's not very clear. A friend of mine and I also had to spend some time figuring out what's wrong. Eventually we noticed the .err file. I mentioned the same issue in #22

The problem is that this repo does not seem to be maintained anymore.

alwaysbemodest commented 2 years ago

even after installing expect, there is still a problem in my machine... it says: expect: spawn id exp4 not open while executing "expect "$ "" (file "../../tester/run-xv6-command.exp" line 25)

QifanWang commented 2 years ago

After installing "gawk", I can run /test-getreadcounts.sh . Same issue in #12.