search

render-rs / render.rs

🔏 A safe and simple template engine with the ergonomics of JSX
https://docs.rs/render
MIT License
238 stars 23 forks source link

support keywords like type/for without resorting to raw #30

Closed daaku closed 4 years ago

daaku commented 4 years ago

fixes #13

daaku commented 4 years ago

I would also argue that support for r#type style attributes should be dropped.

vpzomtrrfrt commented 4 years ago

As long as this covers all the relevant cases, which it looks like it does, I think we could roll back the r# thing since it wasn't even part of a release yet

theashguy commented 4 years ago

Haven't had time to run it yet, but the code looks good.

Schniz commented 4 years ago

I think we could roll back the r# thing since it wasn't even part of a release yet

I agree. Can we roll it back on this PR? 😁

daaku commented 4 years ago

I think better to split things into smaller changes - just generally helps imho.. What if this didn't actually work for all cases and we wanted to revert just this change? I'll send another pull request reverting support for r# style attributes.

Schniz commented 4 years ago

Makes sense. Thanks. I’ll merge it when I will be next to a computer 👨‍💻