Keep comments like `ratchet:actions/setup-java@v4` when creating PRs - Githubissues

renovatebot / renovate

Home of the Renovate CLI: Cross-platform Dependency Automation by Mend.io

https://mend.io/renovate

GNU Affero General Public License v3.0

17.62k stars 2.32k forks source link

Keep comments like `ratchet:actions/setup-java@v4` when creating PRs #28645

Open HonkingGoose opened 6 months ago

HonkingGoose commented 6 months ago

Describe the proposed change(s).

Renovate should keep comments like ratchet:actions/setup-java@v4 when creating the update PR.

Wanted behavior

- uses: "actions/setup-java@387ac29b308b003ca37ba93a6cab5eb57c8f5f93" # ratchet:actions/setup-java@v4
+ uses: "actions/setup-java@99b8673ff64fbf99d8d325f52d9a5bdedb8483e9" # ratchet:actions/setup-java@v4

Bugged behavior

- uses: "actions/setup-java@387ac29b308b003ca37ba93a6cab5eb57c8f5f93" # ratchet:actions/setup-java@v4
+ uses: "actions/setup-java@99b8673ff64fbf99d8d325f52d9a5bdedb8483e9" # v4

See how Renovate strips the ratchet:actions/setup-java@ part.

More context

HonkingGoose commented 6 months ago

Hi @art-shutter, you created the "support ratchet comments" PR (#27846). Do you want to work on this bug?