Open rarkins opened 1 month ago
While looking into this, please also check on whether the PR list is cached reliably too.
Summarizing the tasks for this PR:
Platform | getPrList() Storage Location |
Updates Storage On: createPr() |
Updates Storage On: updatePr() |
---|---|---|---|
Azure | local config | ✅ | ✅ |
Bitbucket Cloud | repo cache | ✅ | ❌ |
Bitbucket Server | local config | ✅ | ✅ |
CodeCommit | local config | ❌ | ❌ |
Gerrit | function not used | ❌ | ❌ |
Gitea | repo cache | ✅ | ✅ |
Github | local config & repo cache | ✅ | ✅ |
Gitlab | local config | ✅ | ❌ |
updatePr()
storage updates for:
Consider implementation for:
For each platform, verify:
PR Creation
getPrList()
immediately after creationgetPrList()
on subsequent runs -- if cache is usedPR Updates
getPrList()
after updatePr()
callgetPrList()
on subsequent runs -- if cache is usedExternal Updates -- if cache is used
getPrList()
reflects changes made via platform UI ie. cache.reconcile function is working as expectedCode Commit can be skipped as it's deprecated. Gerritt also unless it's really quick. Ideally all platforms would update the PR cache correctly too
Describe the proposed change(s).
It's important that
platform.getPrList()
returns an accurate list, particularly after PRs are created.Check each platform to make sure that createPr() and updatePr() both mutate/update any saved PR lists for each platform.