search

replicatedhq / dockerfilelint

An opinionated Dockerfile linter.
https://www.fromlatest.io
MIT License
989 stars 83 forks source link

Fix handling of --start-period option for HEALTHCHECK #167

Closed egoexpress closed 1 month ago

egoexpress commented 3 years ago

As adressed in #166 is_valid_healthcheck() throws an error when the '--start-period' option is provided. This is due a broken regexp that doesn't handle the dash in the option name. This PR fixes this.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

proinsias commented 3 years ago

Any chance of a merge of this?

proinsias commented 2 years ago

@marccampbell – another request for a review and merge when you get a chance!