search

replit / polygott

Base Docker image for the Repl.it evaluation server
https://replit.com
MIT License
395 stars 103 forks source link

Revert "kill X before possibly starting another X" #188

Closed dan-stowell closed 3 years ago

dan-stowell commented 3 years ago

Reverts replit/polygott#180

I'm seeing many errors that look like this when running pygame repls:

 bash -c polygott-x11-vnc q && DISPLAY=:0 run-project
......pygame 2.0.0 (SDL 2.0.12, python 3.8.6)
Hello from the pygame community. https://www.pygame.org/contribute.html
Warning, no sound
X Error of failed request:  BadMatch (invalid parameter attributes)
  Major opcode of failed request:  42 (X_SetInputFocus)
  Serial number of failed request:  195
  Current serial number in output stream:  196
exit status 1

With this revert, we'll tradeoff some hangs for being able to start X11 at all.

replbot commented 3 years ago

Good work, this PRs short and easy to review! Promoting to bop.

replbot commented 3 years ago

unbooping: tests don't pass