search

replit / polygott

Base Docker image for the Repl.it evaluation server
https://replit.com
MIT License
395 stars 103 forks source link

Use the manifest_tool to create the Docker build context #219

Closed lhchavez closed 3 years ago

lhchavez commented 3 years ago

This change improves the stability of the Docker build context by explicitly constructing it ourselves instead of letting Docker handle that. Notably, this makes our files be immune to changes in the user's umask (which makes the files have different permission bits, which always invalidates the build cache) and mtime (which according to some StackOverflow lore may invalidate the build cache in some cases, but I'm not quite positive about this).

replbot commented 3 years ago

Good work, this PRs short and easy to review! Promoting to bop.

replbot commented 3 years ago

prebooping: tests are pending

replbot commented 3 years ago

prebooping: tests are pending

replbot commented 3 years ago

unbooping: approved