Closed jonasongg closed 6 months ago
@sopa301 thank you and fixed!
Example repo before and after the optimise timelines option is activated.
Before:
After:
Good inputs @ckcherry23
- [Discuss] When the report is grouped by repos, the various authors under the repo may have different timelines. This discrepancy may make it difficult to compare when different teammates are contributing relatively. We may want to make the timeline duration consistent across a repo group (@damithc). However, when grouping by authors, this doesn't matter.
One option (probably easier too) is to take the stance that 'optimized' timelines isn't suitable for timeline comparisons. What do you all think?
- [Discuss] We may want to think of a more intuitive name for "Optimise timeline", because it is not immediately clear what this feature does to end users. I would suggest something along the lines of "Condense charts".
'Trim'?
@ckcherry23 @damithc thank you for your comments! will do the necessary changes asap.
as for when we are grouping by repos, it shouldn't be too difficult to make the timeline consistent across a group (i think we can just select the minimum and maximum commit date of the group instead of the user). i'm ok to implement either option!
i think "trim timeline" works!
as for when we are grouping by repos, it shouldn't be too difficult to make the timeline consistent across a group (i think we can just select the minimum and maximum commit date of the group instead of the user). i'm ok to implement either option!
@jonasongg This might dilute the effect of the feature, if different authors have authored code at different times. For exampe, if the following author did one more commit in the place pointed by the arrow.
So, I'd rather keep the current behavior first, and revisit this after using it for a while.
@jonasongg BTW, just now I realized the zoom feature and this feature must have lot in common, this that this one is like an auto-zoom. Is there some code reuse? Just curious.
@damithc got it. for the code reuse question, there is a bit of reuse in the sense that the logic to calculate the position of the ramp slices is the same, but the code that this feature adds is just finding the minimum and maximum commit dates
@MarcusTXK the tests were actually added in this PR under optimiseTimeline.cy.js - should I change this?
@jonasongg Ah OK, apologies I missed it. No worries, this works, let's leave it as it is then.
The following links are for previewing this pull request:
Fixes #2162 Part of #2157
Proposed commit message
Other information