search

requests-cache / aiohttp-client-cache

An async persistent cache for aiohttp requests
MIT License
121 stars 21 forks source link

docs: update changelog (release 0.12.4) #288

Closed alessio-locatelli closed 1 month ago

alessio-locatelli commented 1 month ago

@JWCook I have created a tag https://github.com/requests-cache/aiohttp-client-cache/releases/tag/v0.12.4 and a release https://github.com/requests-cache/aiohttp-client-cache/releases/tag/v0.12.4 via GitHub website. That did not trigger a deploy. I have an assumption that the reason is that I did not mark the release as the "latest" immediately.

I decided to run the workflow manually, but it created a pre-release: https://pypi.org/project/aiohttp-client-cache/#history On GitLab CI, for my projects, if the latest tag points to the latest commit, the Poetry build picks up the "latest" version (not a "pre-release"). Perhaps I got confused because I expected a similar behavior.

So, the latest version on PyPI is still aiohttp-client-cache 0.12.3: https://pypi.org/project/aiohttp-client-cache/

Could you please release the latest version and point out what went wrong?

JWCook commented 1 month ago

That's quite strange! You didn't do anything incorrectly, and I saw the same thing when trying to recreate the tag. I noticed it didn't trigger the build step either. I updated the workflows to trigger on all tags (instead of tags matching v*), and it worked. No idea why! 🤷

That trigger has worked fine since I initially added it here, so something on the GitHub Actions end changed or broke since the last release on October 4. The docs don't indicate any syntax changes, though.

The pre-release behavior is defined here: https://github.com/requests-cache/aiohttp-client-cache/blob/369dfd865c5891df4c0bd9d4d0ecb9b7a3d9a2db/.github/workflows/deploy.yml#L33-L38 I.e., "If it's not triggered by a tag, assume it's a (manual) pre-release." That could be changed if we need to do a non-tagged stable release at some point.

Anyway, 0.12.4 is on PyPI now.