Closed alessio-locatelli closed 3 weeks ago
Attention: Patch coverage is 55.55556%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 96.17%. Comparing base (
26bf273
) to head (fb00280
). Report is 5 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
aiohttp_client_cache/backends/sqlite.py | 50.00% | 2 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Closes https://github.com/requests-cache/aiohttp-client-cache/issues/241
MRE
1st run (there is no cache file yet)
We can see the warning inside
get_connection()
after theyield
:2nd run (a cache file already exists)
We can see the warning inside the
def read()
:Notes
Not related to this PR and the mentioned issue, but Redis and MongoDB must have the
def close()
method too because the connections must be closed.