search

requests / toolbelt

A toolbelt of useful classes and functions to be used with python-requests
https://toolbelt.readthedocs.org
Other
989 stars 186 forks source link

Handle pickle in `BaseUrlSession` for `base_url` #376

Closed Inokinoki closed 2 months ago

Inokinoki commented 3 months ago

Resolve https://github.com/requests/toolbelt/issues/375

Inokinoki commented 3 months ago

Can you add something to the change log too?

Should I put in 1.0.0 section?

sigmavirus24 commented 3 months ago

Nope. Create a 1.1.0 section. 1.0 was already released

sigmavirus24 commented 3 months ago

Can you look into the test failures? I don't see them in main

Inokinoki commented 2 months ago

Can you look into the test failures? I don't see them in main

Done, but it's quite weird that two of the content length of the recorded data are wrong:

For example, httpbin:

'{\n  "args": {}, \n  "headers": {\n    "Accept": "*/*", \n    "Accept-Encoding": "gzip, deflate", \n    "Host": "httpbin.org", \n    "User-Agent": "python-requests/2.8.1"\n  }, \n  "origin": "<IPADDR>", \n  "url": "https://httpbin.org/get"\n}\n'
>>> len(_)
233
sigmavirus24 commented 2 months ago

Things failing on 3.12 are failing on a deprecation warning that needs to be fixed elsewhere.

Thanks for working through this!