resilient-tech / india-compliance

Simple, yet powerful compliance solutions for Indian businesses
https://indiacompliance.app
GNU General Public License v3.0
152 stars 141 forks source link

fix: Validate when GSTIN field is empty #2643

Closed Ninad1306 closed 2 months ago

Ninad1306 commented 2 months ago

Issue Reference: https://support.frappe.io/helpdesk/tickets/22783

Huly®: IC-2767

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.05%. Comparing base (8b93f8a) to head (5c8d7e2). Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
.../gst_india/overrides/subcontracting_transaction.py 0.00% 2 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/resilient-tech/india-compliance/pull/2643/graphs/tree.svg?width=650&height=150&src=pr&token=RBZLDO9SOL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=resilient-tech)](https://app.codecov.io/gh/resilient-tech/india-compliance/pull/2643?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=resilient-tech) ```diff @@ Coverage Diff @@ ## develop #2643 +/- ## ======================================== Coverage 60.05% 60.05% ======================================== Files 120 120 Lines 11572 11572 ======================================== Hits 6949 6949 Misses 4623 4623 ``` | [Files with missing lines](https://app.codecov.io/gh/resilient-tech/india-compliance/pull/2643?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=resilient-tech) | Coverage Δ | | |---|---|---| | [.../gst\_india/overrides/subcontracting\_transaction.py](https://app.codecov.io/gh/resilient-tech/india-compliance/pull/2643?src=pr&el=tree&filepath=india_compliance%2Fgst_india%2Foverrides%2Fsubcontracting_transaction.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=resilient-tech#diff-aW5kaWFfY29tcGxpYW5jZS9nc3RfaW5kaWEvb3ZlcnJpZGVzL3N1YmNvbnRyYWN0aW5nX3RyYW5zYWN0aW9uLnB5) | `29.06% <0.00%> (ø)` | | [![Impacted file tree graph](https://app.codecov.io/gh/resilient-tech/india-compliance/pull/2643/graphs/tree.svg?width=650&height=150&src=pr&token=RBZLDO9SOL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=resilient-tech)](https://app.codecov.io/gh/resilient-tech/india-compliance/pull/2643?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=resilient-tech)