Closed akloeckner closed 2 years ago
FYI: I've acknowledged this PR but didn't have time to look into it yet.
Thanks for the feedback! We're in no hurry, things are working swiftly already: I have just kept my once installed app from my test branch. ;-)
Made minor changes:
The manifest changes haven't made it to the PR yet.
Yeay! Thanks.
I believe start_url
is a requirement, though. I just did a quick test on my mobile and didn't get the "install" option. I'll check again on a laptop as soon as I find time.
I've misinterpreted my local changes after all this time and thought that this was something that I've added when experimenting... Should definitively restore it then.
I verified that start_url is needed to show the install button on my Windows Chrome. I opened #838 to fix this.
fixes #819
This
The service worker's scope is automatically just the path to its js file. (See Google's primer on it.)
The ingress mode of the addon can disable the service worker via
window.IN_INGRESS = true
. See PR there: https://github.com/resoai/TileBoard-addon/pull/32.