feat: make tileboard installable as web apk

resoai / TileBoard

A simple yet highly configurable Dashboard for HomeAssistant

MIT License

1.63k stars 278 forks source link

feat: make tileboard installable as web apk #822

Closed akloeckner closed 2 years ago

akloeckner commented 2 years ago

fixes #819

This

adds a dummy service worker with a fetch handler
increases the favicon size to 512px and adds a vector source graphic
adds a start_url to the webmanifest

The service worker's scope is automatically just the path to its js file. (See Google's primer on it.)

The ingress mode of the addon can disable the service worker via window.IN_INGRESS = true. See PR there: https://github.com/resoai/TileBoard-addon/pull/32.

rchl commented 2 years ago

FYI: I've acknowledged this PR but didn't have time to look into it yet.

akloeckner commented 2 years ago

Thanks for the feedback! We're in no hurry, things are working swiftly already: I have just kept my once installed app from my test branch. ;-)

rchl commented 2 years ago

Made minor changes:

optimized SVG
declared SVG favicon in the manifest and added 256x256 size also
small style changes

akloeckner commented 2 years ago

The manifest changes haven't made it to the PR yet.

akloeckner commented 2 years ago

Yeay! Thanks.

I believe start_url is a requirement, though. I just did a quick test on my mobile and didn't get the "install" option. I'll check again on a laptop as soon as I find time.

rchl commented 2 years ago

I've misinterpreted my local changes after all this time and thought that this was something that I've added when experimenting... Should definitively restore it then.

akloeckner commented 2 years ago

I verified that start_url is needed to show the install button on my Windows Chrome. I opened #838 to fix this.