search

resque / php-resque

An implementation of Resque in PHP.
MIT License
216 stars 77 forks source link

Fix issue with PID entries in Redis not being deleted for failed jobs #73

Closed martinbutt closed 1 year ago

martinbutt commented 1 year ago

Replaces https://github.com/resque/php-resque/pull/50

martinbutt commented 1 year ago

And as a note, this fixed the Redis leak and has been working perfectly in a high traffic (100M+ keys per day) production env since it was committed a couple of years ago.

pprkut commented 1 year ago

This will "conflict" with #56.

@danhunsaker I think you can merge this one first and then I'll adjust the namespaces pull request for it.

danhunsaker commented 1 year ago

Drat it all. Missed these comments before merging #56...

danhunsaker commented 1 year ago

@martinbutt - Can we rebase and address the comment(s) on this so we can GTM?

martinbutt commented 1 year ago

It was easier to do a new PR. See #74.