investigate + fix why models are not being included/calculated in simplecov test coverage

restarone / violet_rails

an app engine for your business. Seamlessly implement business logic with a powerful API. Out of the box CMS, blog, forum and email functionality. Developer friendly & easily extendable for your next SaaS/XaaS project. Built with Rails 6, Devise, Sidekiq & PostgreSQL

https://violet.restarone.solutions

MIT License

96 stars 44 forks source link

investigate + fix why models are not being included/calculated in simplecov test coverage #245

Closed donrestarone closed 2 years ago

donrestarone commented 2 years ago

@Pralish this is the next infrastructure upgrade we are looking to do after we integrate the change for deploying to violet rails apps over Github Actions

Pralish commented 2 years ago

@donrestarone , I tracked it down to this line:

add_filter "app/models/"

This was done some 15 months ago. I removed the line and models got included in simplecov test coverage. Do you remember why models were skipped before?

Before:

After:

donrestarone commented 2 years ago

@Pralish yup, I added that a while back because the model coverage isn't accurate.

Notice the 0% coverage for the user and subdomain models, we should see more coverage.

Pralish commented 2 years ago

Okay, got it. Thanks