search

restpackio / restpack-csharp

Restpack.io C# client for HTML to PDF API, and Screenshot API
https://restpack.io
MIT License
4 stars 2 forks source link

Async Support #5

Closed kinetiq closed 3 years ago

kinetiq commented 4 years ago

Hey, I could use async support. If I do a pull request with some basic async support, will you accept it?

Thanks!

namirali commented 4 years ago

any improvements are welcomed @kinetiq

kinetiq commented 4 years ago

@namirali Hey, I am working on this, but I see some issues that give me pause.

In the latest version you released for me (thanks for that!), the namespace was changed from Pdf2Html to Html2Pdf. That is more correct and seems reasonable, however I do not see that change in this repo.

In fact, the last change logged in github was 8 months ago. That makes me think someone is working from a different repo (locally, etc...) and changes are not being checked in here.

FYI, the name change also breaks your documentation in some places.

Finally, there is no solution file here. That means any time I save, it's going to prompt me to create one, and what gets created may be out of sync with what you are using.

Any chance you can look into these issues? Unless I'm mistaken, they will prevent anyone from contributing without creating additional work for you.