search

rethinkdb / rethinkdb-python

Python driver for RethinkDB
https://rethinkdb.com/api/python/
Apache License 2.0
64 stars 34 forks source link

pylintrc disable=W0613 #289

Closed cclauss closed 1 year ago

cclauss commented 1 year ago

The next step after #288

Reason for the change If applicable, link the related issue/bug report or write down in few sentences the motivation.

Description A clear and concise description of what did you changed and why.

Code examples If applicable, add code examples to help explain your changes.

Checklist

References Anything else related to the change e.g. documentations, RFCs, etc.

pylint rethinkdb
************* Module rethinkdb.cli.main
rethinkdb/cli/main.py:77:0: W0613: Unused argument 'args' (unused-argument)
rethinkdb/cli/main.py:77:0: W0613: Unused argument 'kwargs' (unused-argument)
************* Module rethinkdb.cli._index_rebuild
rethinkdb/cli/_index_rebuild.py:32:22: W0613: Unused argument 'ctx' (unused-argument)
************* Module rethinkdb.cli._restore
rethinkdb/cli/_restore.py:29:16: W0613: Unused argument 'ctx' (unused-argument)
************* Module rethinkdb.cli._dump
rethinkdb/cli/_dump.py:29:13: W0613: Unused argument 'ctx' (unused-argument)
************* Module rethinkdb.cli._export
rethinkdb/cli/_export.py:29:15: W0613: Unused argument 'ctx' (unused-argument)
************* Module rethinkdb.cli._import
rethinkdb/cli/_import.py:29:15: W0613: Unused argument 'ctx' (unused-argument)

-----------------------------------
Your code has been rated at 9.97/10

make: *** [Makefile:106: lint] Error 4
Error: Process completed with exit code 2.

@lsabi Your review, please.

gabor-boros commented 1 year ago

Hey @cclauss,

Thanks for the PR. Actually, this is my fault. Instead of ctx I could have used _, and that should be the temporary solution. Disabling unused variable check could cause more truble than the benefit it brings.