Closed liuhangbin closed 8 months ago
Don't we need the same improved error message in
gen_hook_skel
?
After make ebpf
, cargo build
will pass. So I think there is no need to add another hit.
Don't we need the same improved error message in
gen_hook_skel
?After
make ebpf
,cargo build
will pass. So I think there is no need to add another hit.
That's right. But we might change the order of the calls in build.rs
; or someone could manually remove one of the BPF object files, etc. I agree those are not likely events, but having the right error message from the beginning will help maintenance.
Since #237 the BPF part is not handled by
cargo build
anymore. Users who are not aware of this and runcargo build
directly will get error:The users could not get what should do to avoid this error. Let's add an error hint so they can know how to avoid it. Here is what it looks like: