search

retis-org / retis

Tracing packets in the Linux networking stack & friends
https://retis.readthedocs.io/en/stable/
100 stars 14 forks source link

Better handle packets we don't recognize #429

Closed atenart closed 1 month ago

atenart commented 1 month ago

Fixes #428.

vlrpl commented 1 month ago

the change looks good to me. Just a tiny nit on patch 3/4 commit message. I think $subject is a placeholder, and while at it, the last line (only looking like a valid ethertype, but what can we do? has unmatching parentheses.

atenart commented 1 month ago

the change looks good to me. Just a tiny nit on patch 3/4 commit message. I think $subject is a placeholder, and while at it, the last line (only looking like a valid ethertype, but what can we do? has unmatching parentheses.

$subject was intentional because I was a bit lazy I guess to repeat the title :) But you're right; I fixed the two above issues.