retrooper / packetevents

Precision meets performance—a powerful tool for mastering Minecraft packet manipulation with speed and finesse.
GNU General Public License v3.0
555 stars 150 forks source link

Incorrect Legacy Block Mappings for Short and Tall Grass #1052

Open Axionize opened 2 weeks ago

Axionize commented 2 weeks ago

To start off with some definitions. Short grass is grass that looks like this. 1

Tall grass is grass that looks like this. 2

StateTypes.TALL_GRASS is correctly returned for Tall Grass on 1.21 and StateTypes.SHORT_GRASS is correctly returned for Short Grass on 1.21.

The StateTypes.TALL_GRASS is returned for Short Grass on 1.8 and StateTypes.PEONY is returned for Tall Grass on 1.8 Is this intentional? Short grass is called "tallgrass" in 1.8 so does this inconsistency exist to accommodate legacy Minecraft's actual block names? If so, what's the intended way to deal with these blocks consistently across versions?