search

retrooper / packetevents

Precision meets performance—a powerful tool for mastering Minecraft packet manipulation with speed and finesse.
GNU General Public License v3.0
555 stars 150 forks source link

Fix legacy mappings for grass and tallgrass variants #1053

Open Axionize opened 2 weeks ago

Axionize commented 2 weeks ago

Fixes https://github.com/retrooper/packetevents/issues/1052

Axionize commented 2 weeks ago

@booky10

booky10 commented 2 weeks ago

There is a syntax error in your mappings, see build logs

Axionize commented 2 weeks ago

@booky10 fixed

Axionize commented 2 weeks ago

An upstream issue in grim hinges on this being fixed. I'd appreciate this being done as soon as you have time.

booky10 commented 2 weeks ago

I'll hopefully get this done later today, I still want to do some testing before merging to ensure this works properly

Axionize commented 1 week ago

Items are similar broken/incorrect just like the blocks. An additional hurdle is that item mappings also don't appear to use blockstates? (or I guess itemstates?).

For example 175:2 corresponds to tallgrass and 175:3 corresponds to large ferns. Every 175 variant is considered a large fern. I don't really care since I only care about the hitboxes of these blocks (and they're all the same) but someone else down the line might.

Can we make item mappings work with data states?