retrooper / packetevents

PacketEvents is emerging as a strong contender in the realm of Minecraft packet processing libraries. Designed to simplify packet manipulation while delivering high performance, this powerful tool aims to demystify the complexities of projects utilizing packets.
GNU General Public License v3.0
513 stars 148 forks source link

Sychronization in injector accomplishes nothing #246

Closed MWHunter closed 2 years ago

MWHunter commented 2 years ago

https://github.com/retrooper/packetevents/blob/bb2e9902c9173f67dc37636ffe9fa600f250abc7/spigot/src/main/java/io/github/retrooper/packetevents/handlers/modern/early/EarlyChannelInjectorModern.java#L130

This does nothing, synchronizing a local variable doesn't synchronize to the object it is pointing to

retrooper commented 2 years ago

Fixed in https://github.com/retrooper/packetevents/commit/6123ae9744eabddf681063b5f2036e308ee2364b