UI selection refresh bug

reupen / album_list_panel

Album list panel for Columns UI

https://yuo.be/album-list-panel

GNU Lesser General Public License v3.0

44 stars 1 forks source link

UI selection refresh bug #287

Open regorxxx opened 4 days ago

regorxxx commented 4 days ago

On large libraries, selecting the first node and clicking Ctrl + Shift + END does not refresh the selection highlighting until all items are processed (may take a few seconds).

CUI1

BUT doing the same via mouse (shift + scroll + Click at end) works fine.

CUI2

reupen commented 4 days ago

The basic key combination for selecting to the last item is Shift+End.

Ctrl+End (without Shift) scrolls to the last item, and Ctrl+Shift+End is like Shift+End but it adds to the current selection (if more than one item was already selected).

Edit: I've seen a slight difference in the performance now (compared to using the mouse). Will have to investigate why there seems to be a discrepancy...

regorxxx commented 3 days ago

Both Ctrl + Shift + End and Shift + End exhibit the same problem as noted in your edit.

EDIT: my first post was wrong, I obviously was talking about Ctrl + Shift + End, not just Ctrl + End.

regorxxx commented 1 day ago

So, unless you're somehow seeing better performance from DUI Album List (generally, the opposite is my experience to be honest 😄

About this, I suppose you deleted it because you tested it.. but yep. Opening the DUI album list, doing the same, in both cases is pretty faster. The UI is refreshed immediately in both cases.

Using the mouse + scrolling, it's totally immediate. Selection is processed and sent to playlist in less than a second for 90K items.
Using Shift + End, selection is immediately refreshed. Then it waits until all is processed and scrolls to end. Again takes the same time (<1 sec).

On CUI:

Behavior as described at first post. Processing takes 2-3 seconds.

reupen commented 23 hours ago

To be honest, after taking timing measurements, I haven't measured a discrepancy between mouse and keyboard selections (contrary to your GIFs, I realise).

DUI is faster in this case, yes. I think it's doing something fundamentally different. Album list panel is asking the tree view to update the selection state of each tree item while DUI doesn't seem to be. I'm guessing it's maintaining the selection state on its end and changing the styles when the tree view renders. You can also see some strange behaviour when dark mode is enabled, if you press Ctrl+Space a few times or Ctrl+Up or Down.

Is the current speed of selecting all items problematic for you, or did you just notice a slowness and report it?