search

rev087 / fancy-new-file

Create or open files and directories in Github's Atom by typing a relative path.
MIT License
9 stars 14 forks source link

New file is opened in existing window instead of new one. #16

Closed Trudko closed 9 years ago

Trudko commented 10 years ago

In issue Stay in window. #11 few people wanted new file to open in same window instead of new one, which IMHO make sense. @rev087 Can you please merge?

silentvick commented 9 years ago

I've tried it on my local copy, but it didn't work. Does it work for you, @Trudko ?

Trudko commented 9 years ago

@silentvick It did, I will try it again tomorrow. Maybe api has changed. What version of Atom and OS do you have?

silentvick commented 9 years ago

@Trudko , I have Atom v.0.158.0 on Linux Mint 17 (x64)

Trudko commented 9 years ago

@silentvick thanks. Try to test it quickly, but I couldn't reproduce the original problem :) I will need bit more time to play with. Right now before Christmas, it's bit tricky a lot of things to do in work. Sorry about delay.

silentvick commented 9 years ago

@Trudko , it's ok :)

Trudko commented 9 years ago

@silentvick i really can't reproduce the original bug :) Do you still have the problem?

silentvick commented 9 years ago

@Trudko , sorry for the late response. I've managed to solve that issue. It appeared to be a cache problem. Atom compiles cofee-scripts in ~/.atom/compile-cache/cofee directory. And for some reason it was using an old cached code. So I just had to clear the cache and that solved my problem. Anyway, thanks for the PR and for your help! :)

Trudko commented 9 years ago

@silentvick so did my pull request work for you ? :) And you are welcome ofc!

silentvick commented 9 years ago

@Trudko , yep, it works fine now :)

stdavis commented 9 years ago

:+1: on a merge for the PR. Would love to have the new file open in the same window.

Thanks for the awesome package.

Trudko commented 9 years ago

@silentvick @stdavis and others, I have decied to fork this package and I have published it :) https://atom.io/packages/advanced-new-file. I fix this and one other bug I found and also added posibility of creating multiple files at once(by comma separation). Please check :)

Trudko commented 9 years ago

Closing the pull request it was implemented in package mentioned above.