[ISSUE-REVERT]: closeAfterOAuthFlow should be enable unless its explicitly specify (disable) false in case of FieldMappings exist - Githubissues

revertinc / revert

Revert makes it incredibly easy to build integrations with any third party API

https://revert.dev

GNU Affero General Public License v3.0

948 stars 74 forks source link

[ISSUE-REVERT]: closeAfterOAuthFlow should be enable unless its explicitly specify (disable) false in case of FieldMappings exist #576

Closed Nabhag8848 closed 6 months ago

Nabhag8848 commented 6 months ago

Describe the bug

When FeildMappings is Enabled (SDK), closeAfterOAuthFlow should be enable unless its explicitly specify (disable) false and incase when it is true, renderStageSuccess should not run code related to fieldMappings and assume they are not interested in fieldMappings regardless of FieldMappingAccountConfig.

To Reproduce Steps to reproduce the behavior:

Two Cases:

One:

Connect with FieldMappings Config
ignore closeAfterOAuthFlow, that is true
will reproduce follwoing error

Two:

Connect with FieldMappings Config
closeAfterOAuthFlow set to true
it will run fieldMappingsCode and will give errors.

Expected behavior

If Ignored closeAfterOAuthFlow means make it true explicitly internally and assume users are not interested in fieldMappings.

Screenshots

Breaks