Closed Nabhag8848 closed 6 months ago
@Nabhag8848 is attempting to deploy a commit to the OpenInt Team on Vercel.
A member of the Team first needs to authorize it.
Thank you for following the naming conventions for pull request titles! 🙏
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
revert-client | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 30, 2024 4:14am |
Description
when user is interested in fieldMappings explictly specify closeAfterOAuthFlow: false and if not specified it will assume customers are not interested in fieldMappings regardless of AccountFieldMappingsConfig.
Closes #576
Four Cases:
When FieldMapping Config is there:
closeAfterOAuthFlow: true
: customers are not interested in fieldMappings regardless of config.closeAfterOAuthFlow: false
: customers are interested in fieldMappings.When FiledMapping Config is not there (Attaching Demo of this as it is little tricky):
closeAfterOAuthFlow: true
: customers are not interested in fieldMappings it will close.closeAfterOAuthFlow: false
: customers are interested in fieldMappings but there is not config so it will show the container to close but won't show the filedMappings.FieldMappingConfig: false(not there), closeAfterOAuthFlow: true
https://github.com/revertinc/revert/assets/65061890/c5c7682c-b450-40d9-8cf0-537b2bb645a7
FieldMappingConfig: false(not there), closeAfterOAuthFlow: false
https://github.com/revertinc/revert/assets/65061890/8703e409-87a6-4def-b05a-56e60a994578
Type of change
Checklist: