search

reviewdog / action-flake8

Runs flake8 with Reviewdog :dog:
https://github.com/reviewdog/reviewdog
MIT License
16 stars 7 forks source link

Reviewdog Github Token write permissions #14

Closed rickstaa closed 3 years ago

rickstaa commented 3 years ago

It looks like this being a fork of another repository breaks the reviewdog github-pr-review feature (see this github action log).

image

I opened a ticket with the GitHub support to ask them to detach it.

rickstaa commented 3 years ago

@haya14busa Sorry to bother you but can you maybe add your approval to the ticket above. It is a ticket to detach this action from the upstream fork. I had to do this because the release action is failing. Thanks a lot in advance!

haya14busa commented 3 years ago

p-r #13 is actually from forked repo, so it's expected. image

rickstaa commented 3 years ago

@haya14busa Ah I see. I thought it was because this is a fork of another repository. Do you think there is not need to detach the fork?

haya14busa commented 3 years ago

No need to detach the fork.

rickstaa commented 3 years ago

@haya14busa Great thanks, I will notify the GitHub agent.

rickstaa commented 3 years ago

@haya14busa The release action still appears to be broken. It, however, does not give an informative warning message (see the log). Are you sure this is not caused by the repository being a fork? I use the same action.yml file on other repositories (see https://github.com/rickstaa/action-get-semver/pull/6)

haya14busa commented 3 years ago

dup: https://github.com/reviewdog/action-flake8/issues/1#issuecomment-750791957

rickstaa commented 3 years ago

@haya14busa Ah it did get posted after all sorry for that. The comment did not show up on my pc.