search

reviewdog / action-languagetool

Run languagetool with reviewdog :dog:
https://github.com/marketplace?type=actions&query=reviewdog
MIT License
39 stars 20 forks source link

Allow running as bitbucket pipe #22

Open taraspos opened 3 years ago

taraspos commented 3 years ago

Hey!

I added all the needed changes to be able to run this as bitbucket pipe. However, bitbucket allows running pipes only from public images.

Would it be possible to publish this to Docker Hub as reviewdog/action-languagetool:1.5.0 #19?

I had to add setting the default values in the entrypoint.sh script itself. Even if pipe.yml supports the default key, it doesn't set the value automatically and needs to be set in the code :/

This PR depends on https://github.com/reviewdog/reviewdog/pull/815

shogo82148 commented 3 years ago

it sounds good. But, I think The BitBucket pipe should be in a separated repository from the GitHub Action. We currently use a Docket GitHub Action now, but we might migrate into a Composite Run GitHub Action (e.g. https://github.com/reviewdog/action-golangci-lint/pull/46) or other action types in the future. Targeting only GitHub Actions makes it easier to migrate.

@haya14busa How do you think?

taraspos commented 3 years ago

Separate repo is fine for me, I just wanted to reuse all the scripting without the need to copy&paste it.