search

reviewdog / action-shellcheck

Run shellcheck with reviewdog
https://github.com/marketplace?type=actions&query=reviewdog
MIT License
102 stars 20 forks source link

filter_mode: change default from `added` to `file` #25

Closed Slamdunk closed 3 years ago

Slamdunk commented 3 years ago

Hi, I was hit hard by the default setting filder_mode: added: a developer of ours removed a line, the producion broke but the Github Action passed.

I propose here to have file as the default method: it's equally fast and doesn't miss such critical cases.

Slamdunk commented 3 years ago

Any feedback @haya14busa ?

grische commented 3 years ago

I have encountered the same problem, someone deleting the initialization of a variable, breaking all references later in the script. For now, I manually added filter_mode: file to all action-shellcheck everywhere, but it would be great to have it as a default.

@Slamdunk There seem to be some conflicts with your PR.

Slamdunk commented 3 years ago

@grische thank you for the notice, PR was ok when I opened it 2 months ago.

Maybe @shogo82148 can review and merge this :crossed_fingers:

review-dog commented 3 years ago

Hi, @Slamdunk! We merged your PR to reviewdog! 🐶 Thank you for your contribution! ✨

We just invited you to join the @reviewdog organization on GitHub. Accept the invite by visiting https://github.com/orgs/reviewdog/invitation. By joining the team, you'll be a part of reviewdog community and can help the maintainance of reviewdog.

Thanks again!