search

rexcyrio / pe

0 stars 0 forks source link

Able to edit the emails of two persons to be the same #5

Open rexcyrio opened 1 year ago

rexcyrio commented 1 year ago

In the UG, it says that the app does not allow users to edit two persons to have the same email

SumatraPDF-3.4.6-64_LMavLwhjxF.png

However, when I tried doing so in the app:

image.png

The app allowed me to edit Bernice's email to match that of Alex's

Expected: an error message to be shown when two persons will end up having the same email

soc-se-bot commented 1 year ago

Team's Response

Valid bug raised. However, we believe the severity is too high. It should instead be a Low severity because it is very unlikely to affect normal operations as it would only occur if someone happened to forget their exact email address and told the librarian their wrong email address which also ends up being the EXACT same email as an existing user in the system.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

can have identical persons through the use of editPerson

image.png persons at index 22 and 23 are identical after using editPerson to match their fields

[original: nus-cs2103-AY2223S2/pe-interim#637] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Valid bug raised. However, we believe the severity is too high. It should instead be a Low severity because it is very unlikely to affect normal operations as it would only occur if someone happened to forget their phone number/email and told the librarian their wrong phone number/email which also ends up being the EXACT same phone number/email as an existing user in the system.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]