Bug: There is a little chance the detection review API did not update all tables.

rfcx / rfcx-api

Core, Media/Assets and MQTT APIs

https://api.rfcx.org/docs/

Apache License 2.0

0 stars 0 forks source link

Bug: There is a little chance the detection review API did not update all tables. #602

Closed grindarius closed 4 months ago

grindarius commented 4 months ago

Sometimees when calling POST /streams/{stream_id}/detections/{start}/review. The API will correctly return 204 but did not appear to update all 3 tables classifier_job_summaries, detections, and detection_reviews table. Now I still cannot reproduce the case but I found from @naluinui who accidentally triggered the bug that the detections table status gets updated but the classifier_job_summaries and detection_reviews does not get updated.

grindarius commented 4 months ago

@naluinui have found some traces of this behavior hidden inside the docs, see linked issues and debugging discussions from rfcx/arbimon#1975

There are 2 problems in this

The backend does an update but it will not be the same as what you would expect it to be since it's a community review system, and the most reviewed status will take it.
The backend did not provide enough parameters to the update call to update the detection status.