rfmoz / grafana-dashboards

Grafana dashboards
Apache License 2.0
1.17k stars 445 forks source link

Allow multi-selection of hosts (and all) #88

Open apenney-beeswax opened 3 years ago

apenney-beeswax commented 3 years ago

In order to allow comparision of multiple haproxy hosts, allow the selection of more than one host.

(I'm not a prometheus expert, I made this change based on the advice of our Grafana Cloud support team, I'm open to changing this in any way you desire. We have about 40 haproxies running and so it's nice to be able to see everything at once.)

apenney-beeswax commented 3 years ago

Not sure if this would be a viable addition but I also added "region" (because we sort by aws region a lot). I could set it to hidden by default so it's not there unless you enable it?

rfrail3 commented 3 years ago

It's nice to have a the option to compare multiple hosts, but it needs a close review to be sure that fits 100% in all the panels that the dashboard have. I'll take it into account.

About the region selection, it's your particular use case. Don't be afraid to adapt the dashboard to your particular company.

Thanks,

JsBergbau commented 2 years ago

Is there any progress? This would really be a great option to compare multiple hosts.

antonengelhardt commented 1 year ago

I tried setting the option "Include All option" to true in Settings > Variables > node but this basically makes all queries faulty. Not a grafana expert here, but i guess this could be a small fix.

skl256 commented 9 months ago

@antonengelhardt Include All option not work because in queries "instance="$node" code (without support regexp, need "instance=~"$node" - with ~).