Closed philouail closed 10 months ago
Thanks for the comments I fixed them, do you have an opinion on the naming thing I was talking about ? replace filteringFunctions
with some kind of name that include quality
instead ? as these functions don't filter.
I added a section to the vignettes to describe general use of these functions.
The naming system is now fixed !
@michaelwitting what do you think ? any ideas for improvement ?
Here is the PR related to the issue #77.
These basic functions return single values and vectors (numeric for all expect for
rowBlank
which is logical).This is a first draft, input is welcome, specifically on:
filteringFunctions
? as they don't really filter but more compute measurement of precision and detection / quality measurement of our data. I think a name reflecting that would be more accurate.qualityFunctions
?rowBlank
thresholdAlso, @jorainer I took your description and code for the rsd and rowRsd, it therefore needs to be removed from CompMetaboTools if you are fine with that.
I am currently writing the vignette but wanted to check if that was what you had in mind for now. Also next I will implement more user friendly function that actually filter the data.