search

rgeo / rgeo-activerecord

RGeo ActiveRecord extensions and tools for spatial connection adapters
Other
89 stars 64 forks source link

`DepthFirst` visitor is no longer part of Rails 6.1 #55

Closed kamipo closed 4 years ago

kamipo commented 4 years ago

Ref https://github.com/rails/rails/pull/36492.

oyeanuj commented 4 years ago

Thanks @kamipo!

@teeparham Is this good to merge?

fuxx commented 4 years ago

Is that merge request still alive?

keithdoggett commented 4 years ago

Thanks for bringing this up @kamipo .

Instead of using version-specific conditionals, it would be better if the Arel::Visitors::DepthFirst.class_eval block is removed altogether, we add an appraisal for activerecord 6.1 (based on the master branch of rails), and then bump the gem version.

This would be consistent with how the gem has been versioned up to this point.

keithdoggett commented 4 years ago

Closing since #57 was merged.